Politics, Weather, Photography, and the Dog
Monday 21 April 2014

I don't know how this little snippet of code got into a project at work (despite the temptation to look at the file's history):

Search = Search.Replace("Search…", "");

// Perform a search that depends on the Search member being an empty string
// Display the list of things you find

First, I can't fathom why the original developer made the search method dependent on a hard-coded string.

Second, as soon as the first user hit this code after switching her user profile to display Japanese, the search failed.

The fix was crushingly simple:

var localizedSearchPrompt = GetLocalizedString("SearchPrompt");
Search = Search.Replace(localizedSearchPrompt, string.Empty);

(The GetLocalizedString method in this sample is actually a stub for the code that gets the string in the current user's language.)

The moral of the story is: avoid hard-coded strings, just like you've been taught since you started programming.

Monday 21 April 2014 15:31:25 CDT (UTC-05:00)  |  | Software | Work#
Search
On this page....
Head-scratching software bug
Countdowns
The Daily Parker +3209d 17h 20m
My next birthday 7d 18h 11m
To London 49d 04h 59m
Parker's 9th birthday 291d 19h 54m
Categories
Aviation (324) Baseball (110) Best Bars (5) Biking (44) Chicago (869) Cubs (197) Duke (132) Geography (314) Higher Ground (5) Jokes (282) Kitchen Sink (625) London (41) Parker (185) Daily (204) Photography (139) Politics (302) US (1065) World (243) Raleigh (20) Readings (8) Religion (62) San Francisco (84) Software (196) Blogs (72) Business (223) Cloud (89) Cool links (130) Security (98) Travel (177) Weather (676) Astronomy (77) Windows Azure (59) Work (45) Writing (8)
Links
Archive
<August 2014>
SunMonTueWedThuFriSat
272829303112
3456789
10111213141516
17181920212223
24252627282930
31123456
Full archive
Blogroll
About
David Braverman and Parker
David Braverman is a software developer in Chicago, and the creator of Weather Now. Parker is the most adorable dog on the planet, 80% of the time.
Legal
All content Copyright ©2014 David Braverman.
Creative Commons License
The Daily Parker by David Braverman is licensed under a Creative Commons Attribution-Noncommercial-No Derivative Works 3.0 United States License, excluding photographs, which may not be republished unless otherwise noted.
Admin Login
Sign In
Blog Stats
Total Posts: 4441
This Year: 339
This Month: 36
This Week: 4
Comments: 0